Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

float multiplicity #350

Merged
merged 6 commits into from
Jan 13, 2025
Merged

float multiplicity #350

merged 6 commits into from
Jan 13, 2025

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Sep 18, 2024 •
edited
Loading

Description

See changelog. fixes #318 fixes #317

Status

  • Code base linted
  • Ready to go

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.83%. Comparing base (936407e) to head (60f60de).
Report is 2 commits behind head on master.

Additional details and impacted files

@loriab loriab requested a review from bennybp December 18, 2024 14:53
@loriab loriab merged commit 1908ccc into MolSSI:master Jan 13, 2025
17 checks passed
@loriab loriab deleted the floatmult_rb1 branch January 13, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennybp bennybp bennybp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floating point number allowed for molecular charge but not molecular multiplicity
2 participants
@loriab @bennybp